You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Moving the test code into the module where the code lives will help manage tests from the source rather than having every test duplicated in each brand plugin.
The workflow for tagging a module update needs to include running tests locally to ensure they all pass, so that when the module update PR in the plugin runs the tests will pass and we can avoid a series of module releases that fix broken tests not found until the plugin PR is created.
Once tests are all moved to the module level we'll look at how we can automate the module PRs running the tests too. Perhaps we can use the blueprint plugin as a container or use a componentized environment for the module.
Describe the solution you'd like
The tests should be removed from the plugin and added to the module. The cypress config should also be updated to look for tests in the modules and add an environment variable for plugin-specific things like brand plugin id for urls. Any fixtures specific to the test should also be moved into the module.
Modules that have migrated:
CTB
Coming Soon
Staging
Marketplace (with premium plugins tab test)
Notifications
Modules that need tests migrated:
Onboarding
Modules that should have e2e tests written and added:
Ecommerce
Patterns
Help Center
Performance
Describe alternatives you've considered
Additional context
The text was updated successfully, but these errors were encountered:
There is a PR housing the module updates and removal of test files from the plugin at: #576 Here I'll update modules as they are released with test files and remove the appropriate spec files from the plugin.
Is your feature request related to a problem? Please describe.
Moving the test code into the module where the code lives will help manage tests from the source rather than having every test duplicated in each brand plugin.
The workflow for tagging a module update needs to include running tests locally to ensure they all pass, so that when the module update PR in the plugin runs the tests will pass and we can avoid a series of module releases that fix broken tests not found until the plugin PR is created.
Once tests are all moved to the module level we'll look at how we can automate the module PRs running the tests too. Perhaps we can use the blueprint plugin as a container or use a componentized environment for the module.
Describe the solution you'd like
The tests should be removed from the plugin and added to the module. The cypress config should also be updated to look for tests in the modules and add an environment variable for plugin-specific things like brand plugin id for urls. Any fixtures specific to the test should also be moved into the module.
Modules that have migrated:
Modules that need tests migrated:
Modules that should have e2e tests written and added:
Describe alternatives you've considered
Additional context
The text was updated successfully, but these errors were encountered: