-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate module tests to modules #576
Conversation
php-7.1, wp-6.11 replays were recorded for 59b470e.
|
Marking this as draft to be clear it's not ready for merge/release |
… include test files
coming soon 1.1.4, marketplace 1.5.2, notifications 1.1.3 Updating dependencies Lock file operations: 0 installs, 14 updates, 0 removals - Upgrading gettext/gettext (v4.8.8 => v4.8.11) - Upgrading mck89/peast (v1.15.3 => v1.15.4) - Upgrading newfold-labs/wp-module-ai (1.0.1 => 1.0.3) - Upgrading newfold-labs/wp-module-coming-soon (1.1.3 => 1.1.4) - Upgrading newfold-labs/wp-module-data (2.4.2 => 2.4.3) - Upgrading newfold-labs/wp-module-ecommerce (v1.1.1 => v1.1.2) - Upgrading newfold-labs/wp-module-help-center (1.0.13 => 1.0.15) - Upgrading newfold-labs/wp-module-installer (1.0.1 => 1.1.1) - Upgrading newfold-labs/wp-module-marketplace (1.5.1 => 1.5.2) - Upgrading newfold-labs/wp-module-notifications (1.1.2 => 1.1.3) - Upgrading newfold-labs/wp-module-onboarding (1.9.1 => 1.10.1) - Upgrading newfold-labs/wp-module-patterns (0.1.1 => 0.1.3) - Upgrading roave/security-advisories (dev-latest 69dafab => dev-latest 8d05c4f) - Upgrading wp-phpunit/wp-phpunit (6.2.2 => 6.3.0)
* develop: (23 commits) Ran composer update update help center module to 1.0.14 Ran npm audit fix Ran npm update Ran composer update Bump version Add upgrade routine to reset `nfd_data_connection_attempts` option update installer to 1.1.1 update onboarding to 1.10.1 removed outdated rudimentary test change min version to 6.2 remove path fix cypress tests fix composer.lock update tested up to value update data module bump plugin to version 3.0.9 and WP to 6.3 bump onboarding to 1.10.0 Skip tax step, removed in 1.10.0 fix: update help icon to match help center Composer(deps): Bump newfold-labs/wp-module-ctb from 1.0.0 to 1.0.1 ... # Conflicts: # composer.json # composer.lock
* develop: Simplify dot file in the distignore by removing redundant file listings Clean up distignore, distinclude, and reinstate some missing scripts
Ready for review again, now that modules are updated and workflows are updated. Just watching the tests still. |
Proposed changes
Testing out moving cypress test files related to a module into the module repo and then consuming it at the plugin level so we don't have to maintain duplicate tests in each plugin. This way the module code and test which tests the module code will live in the same place.
An example module test update is CTB, it includes fixtures. See the PR to add the test here: newfold-labs/wp-module-ctb#2
For more info track the issue this begins to address: #594
Type of Change
Checklist
Further comments