Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump a few outdate npm packages #1072

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

wpalani
Copy link
Member

@wpalani wpalani commented May 15, 2024

Proposed changes

Update a few WordPress npm packages. dependabot had PRs open for each one but tests were failing. To be sure nothing else is going on, let's merge them in this PR and close the other ones.

@wordpress/compose: ^6.30.0 > ^6.34.0
@wordpress/html-entities: ^3.53.0 > ^3.57.0
@wordpress/i18n: ^4.53.0 > ^4.57.0
@wordpress/icons: ^9.44.0 > ^9.48.0
@wordpress/env: ^9.5.0 > ^9.9.0

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

cypress bot commented May 15, 2024

1 flaky test on run #8319 ↗︎

0 389 50 0 Flakiness 1

Details:

Merge eb04787 into d41d119...
Project: Bluehost Brand Plugin Commit: 268e9fc166 ℹ️
Status: Passed Duration: 24:12 💡
Started: May 15, 2024 2:20 AM Ended: May 15, 2024 2:44 AM
Flakiness  vendor/newfold-labs/wp-module-ecommerce/tests/cypress/integration/Home/commerceHomePage.cy.js • 1 flaky test

View Output Video

Test Artifacts
Commerce Home Page- Next Steps > Verify Next steps when experience level is novice Test Replay Screenshots Video

Review all test suite changes for PR #1072 ↗︎

@BrianHenryIE
Copy link
Contributor

The changelogs in Gutenberg make it impossible to know what's going on, e.g.: https://github.com/WordPress/gutenberg/blob/trunk/packages/html-entities/CHANGELOG.md

I'd bet it's a safe PR but I wish I could be more sure.

Review has been requested on this pull request. It is not required to merge

@wpalani
Copy link
Member Author

wpalani commented May 15, 2024

The changelogs in Gutenberg make it impossible to know what's going on, e.g.: https://github.com/WordPress/gutenberg/blob/trunk/packages/html-entities/CHANGELOG.md

I'd bet it's a safe PR but I wish I could be more sure.

Review has been requested on this pull request. It is not required to merge

The failure on those PRs were coming from the AI Site Gen step. (example: https://github.com/bluehost/bluehost-wordpress-plugin/actions/runs/8941412823/job/24561663863).

These tests were fixed in Onboarding 2.3.0. Here's the PR that fixed them: newfold-labs/wp-module-onboarding#545

@wpalani wpalani merged commit 34fe014 into develop May 15, 2024
5 checks passed
@wpalani wpalani deleted the update/wordpress-npm-packages branch May 15, 2024 16:03
@wpalani wpalani restored the update/wordpress-npm-packages branch May 15, 2024 16:03
@wpalani wpalani deleted the update/wordpress-npm-packages branch May 15, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants