Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/3.12.1 #1139

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Release/3.12.1 #1139

merged 3 commits into from
Jun 20, 2024

Conversation

circlecube
Copy link
Member

Proposed changes

This is an out of cycle release to fix a couple issues:

  1. Plugin page not loading in some cases: https://jira.newfold.com/browse/PRESS1-402
  2. Reinstate migration issues that were disabled in last release but have been fixed.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube self-assigned this Jun 20, 2024
@circlecube
Copy link
Member Author

This fixes 1 so far, I'm still testing 2

Copy link

cypress bot commented Jun 20, 2024

Passing run #8864 ↗︎

0 389 60 0 Flakiness 0

Details:

update migration module to 1.0.7
Project: Bluehost Brand Plugin Commit: 8d8e421626
Status: Passed Duration: 23:12 💡
Started: Jun 20, 2024 9:17 PM Ended: Jun 20, 2024 9:40 PM

Review all test suite changes for PR #1139 ↗︎

Copy link

cypress bot commented Jun 20, 2024

2 failed tests on run #8879 ↗︎

2 340 25 0 Flakiness 0

Details:

Merge 8d8e421 into 5e61b89...
Project: Bluehost Brand Plugin Commit: d643eedf89 ℹ️
Status: Failed Duration: 22:18 💡
Started: Jun 20, 2024 9:19 PM Ended: Jun 20, 2024 9:41 PM
Failed  vendor/newfold-labs/wp-module-ecommerce/tests/cypress/integration/Home/migration.cy.js • 2 failed tests

View Output Video

Test Artifacts
Home page - post migration events with help center > Verify when update nameserver clicked Test Replay Screenshots Video
Home page - post migration events with help center > Verify when connect domain to site clicked Test Replay Screenshots Video

Review all test suite changes for PR #1139 ↗︎

@circlecube
Copy link
Member Author

2 is now updated and should be fixed in this release too. 🥇

@circlecube
Copy link
Member Author

Though the migration module update fixes an issue, it's not related to the migration tests that are failing. Those are testing the custom home screen onboarding steps for sites that migrate which are in the e-commerce module.

@circlecube circlecube merged commit 65b7e31 into main Jun 20, 2024
14 of 22 checks passed
@circlecube circlecube deleted the release/3.12.1 branch June 20, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants