Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/minor lint issues #968

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Fix/minor lint issues #968

merged 1 commit into from
Feb 29, 2024

Conversation

circlecube
Copy link
Member

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube self-assigned this Feb 29, 2024
Copy link

cypress bot commented Feb 29, 2024

Passing run #7474 ↗︎

0 333 24 0 Flakiness 0

Details:

Merge 1688a17 into ee4ab0f...
Project: Bluehost Brand Plugin Commit: 7b1b5c5213 ℹ️
Status: Passed Duration: 19:02 💡
Started: Feb 29, 2024 9:33 PM Ended: Feb 29, 2024 9:52 PM

Review all test suite changes for PR #968 ↗︎

Copy link

cypress bot commented Feb 29, 2024

1 flaky test on run #7475 ↗︎

0 333 24 0 Flakiness 1

Details:

fix some issues reported by lint
Project: Bluehost Brand Plugin Commit: 1688a172cf
Status: Passed Duration: 19:52 💡
Started: Feb 29, 2024 9:33 PM Ended: Feb 29, 2024 9:53 PM
Flakiness  vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/3-ecommerce-onboarding-flow/sitetype-secondary.cy.js • 1 flaky test

View Output Video

Test Artifacts
Get Started Site Type Secondary > Check for Event API call being made when different sub-categories are selected Test Replay Screenshots Video

Review all test suite changes for PR #968 ↗︎

@circlecube circlecube merged commit cb07b24 into develop Feb 29, 2024
7 checks passed
@circlecube circlecube deleted the fix/minot-lint-issues branch February 29, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants