Enable Exif Writers to return a new ArrayBuffer.

blueimp · Jun 20, 2020 · fecacd4 · fecacd4
1 parent af40950
commit fecacd4
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/js/load-image-exif.js b/js/load-image-exif.js
@@ -441,7 +441,7 @@
   }
 
   loadImage.writeExifData = function (buffer, data, id, value) {
-    loadImage.exifWriters[data.exif.map[id]](buffer, data, value)
+    return loadImage.exifWriters[data.exif.map[id]](buffer, data, value)
   }
 
   loadImage.ExifMap = ExifMap

diff --git a/test/test.js b/test/test.js
@@ -2650,7 +2650,14 @@
           expect(data.iptc).to.be.ok
           expect(data.iptc.get('ObjectName')).to.equal('blueimp.net')
           // Reset EXIF Orientation data:
-          loadImage.writeExifData(data.imageHead, data, 'Orientation', 1)
+          var buffer = loadImage.writeExifData(
+            data.imageHead,
+            data,
+            'Orientation',
+            1
+          )
+          // Check if Orientation writer changes image head buffer in place:
+          expect(buffer).to.equal(data.imageHead)
           img.toBlob(function (blob) {
             loadImage.replaceHead(blob, data.imageHead, function (newBlob) {
               loadImage(
@@ -2703,7 +2710,14 @@
             expect(data.iptc).to.be.ok
             expect(data.iptc.get('ObjectName')).to.equal('blueimp.net')
             // Reset EXIF Orientation data:
-            loadImage.writeExifData(data.imageHead, data, 'Orientation', 1)
+            var buffer = loadImage.writeExifData(
+              data.imageHead,
+              data,
+              'Orientation',
+              1
+            )
+            // Check if Orientation writer changes image head buffer in place:
+            expect(buffer).to.equal(data.imageHead)
             return new Promise(function (resolve) {
               data.image.toBlob(function (blob) {
                 data.blob = blob