RM-104: upper bound mypy < 1.5.0 to fix typechecking #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantimjohn
approved these changes
Aug 29, 2023
There was a problem hiding this comment.
Looks good as a short term fix! Any easy way you can think of to track this ticket and lift the cap once it's fixed @Brunope ? Might just link to this Github Issue in a comment above the change:
python/mypy#15891
|
there is a link to the github issue next to the change haha |
|
haha, so embarrassed, was looking at this half screen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python/mypy#15891
installing mypy-1.4.1 fixed this issue