Allow setting systemd unit dirs separately, and get sane defaults from pkg-config #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support setting a different system & user unit directories for systemd. This is necessary since on split /usr systems, system units belong in /lib, while user units belong in /usr/lib.
|
Hmm, I see that the PKG_CHECK_VAR macro is not present in older versions of pkg-config, and I don't care enough to implement it manually. |
|
I "borrowed" some code (see 8ba8bcb) to add the pkgconfig function and merged your original commits. thx |
|
Thanks a lot! |
cschramm
referenced
this pull request
May 6, 2018
Unit files may also get installed to /etc or /lib. Instead pass working configure flags to distcheck.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently blueman uses custom-made
--with-systemdunitdirthat sets top directory for systemd units. This doesn't work for split /usr systems because system units need to go into/lib/systemdwhile user units need to go into/usr/lib/systemd.Replace the custom option with quasi-standard
--with-systemdsystemunitdirand--with-systemduserunitdirthat allow setting both necessary directories separately.Furthermore, default to querying pkg-config for the correct paths from systemd.pc.