headers: support SSRCs with missing zeros (bluenviron/mediamtx#396)

bluenviron · May 29, 2021 · 4f595a1 · 4f595a1
1 parent 150c03a
commit 4f595a1
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/pkg/headers/transport.go b/pkg/headers/transport.go
@@ -161,6 +161,9 @@ func (h *Transport) Read(v base.HeaderValue) error {
 			h.ServerPorts = ports
 
 		case "ssrc":
+			if (len(v) % 2) != 0 {
+				v = "0" + v
+			}
 			tmp, err := hex.DecodeString(v)
 			if err != nil {
 				return err

diff --git a/pkg/headers/transport_test.go b/pkg/headers/transport_test.go
@@ -132,6 +132,28 @@ var casesTransport = []struct {
 			}(),
 		},
 	},
+	{
+		"ssrc odd",
+		base.HeaderValue{`RTP/AVP/UDP;unicast;server_port=8052;client_port=14186;ssrc=B6020AD;mode=PLAY`},
+		base.HeaderValue{`RTP/AVP;unicast;client_port=14186-14187;server_port=8052-8053;ssrc=0B6020AD;mode=play`},
+		Transport{
+			Protocol: base.StreamProtocolUDP,
+			Delivery: func() *base.StreamDelivery {
+				v := base.StreamDeliveryUnicast
+				return &v
+			}(),
+			Mode: func() *TransportMode {
+				v := TransportModePlay
+				return &v
+			}(),
+			ClientPorts: &[2]int{14186, 14187},
+			ServerPorts: &[2]int{8052, 8053},
+			SSRC: func() *uint32 {
+				v := uint32(0x0B6020AD)
+				return &v
+			}(),
+		},
+	},
 }
 
 func TestTransportRead(t *testing.T) {