Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: fix OnResponse() not getting called when playing / recording #290

Merged
merged 2 commits into from
May 28, 2023

Conversation

aler9
Copy link
Member

@aler9 aler9 commented May 28, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2023

Codecov Report

Merging #290 (33abe4b) into main (f254503) will increase coverage by 0.02%.
The diff coverage is 88.09%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #290      +/-   ##
==========================================
+ Coverage   85.89%   85.92%   +0.02%     
==========================================
  Files          95       97       +2     
  Lines        9734     9768      +34     
==========================================
+ Hits         8361     8393      +32     
- Misses       1077     1079       +2     
  Partials      296      296              
Impacted Files Coverage Δ
server_session.go 77.24% <ø> (ø)
client.go 72.94% <83.14%> (-0.70%) ⬇️
client_reader.go 90.56% <90.56%> (ø)
async_processor.go 100.00% <100.00%> (ø)
client_conn_closer.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aler9 aler9 merged commit 1e1e10b into main May 28, 2023
7 checks passed
@aler9 aler9 deleted the bug/on_response branch May 28, 2023 10:12
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants