rtsp server: log decode errors

bluenviron · Oct 31, 2022 · f7fdd60 · f7fdd60
1 parent 584cc93
commit f7fdd60
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/internal/core/rtsp_server.go b/internal/core/rtsp_server.go
@@ -389,14 +389,22 @@ func (s *rtspServer) OnPause(ctx *gortsplib.ServerHandlerOnPauseCtx) (*base.Resp
 	return se.onPause(ctx)
 }
 
-// OnPacketRTP implements gortsplib.ServerHandlerOnPacket.
+// OnPacketRTP implements gortsplib.ServerHandlerOnPacketRTP.
 func (s *rtspServer) OnPacketRTP(ctx *gortsplib.ServerHandlerOnPacketRTPCtx) {
 	s.mutex.RLock()
 	se := s.sessions[ctx.Session]
 	s.mutex.RUnlock()
 	se.onPacketRTP(ctx)
 }
 
+// OnDecodeError implements gortsplib.ServerHandlerOnOnDecodeError.
+func (s *rtspServer) OnDecodeError(ctx *gortsplib.ServerHandlerOnDecodeErrorCtx) {
+	s.mutex.RLock()
+	se := s.sessions[ctx.Session]
+	s.mutex.RUnlock()
+	se.onDecodeError(ctx)
+}
+
 // apiSessionsList is called by api and metrics.
 func (s *rtspServer) apiSessionsList(req rtspServerAPISessionsListReq) rtspServerAPISessionsListRes {
 	select {

diff --git a/internal/core/rtsp_session.go b/internal/core/rtsp_session.go
@@ -394,3 +394,8 @@ func (s *rtspSession) onPacketRTP(ctx *gortsplib.ServerHandlerOnPacketRTPCtx) {
 		})
 	}
 }
+
+// onDecodeError is called by rtspServer.
+func (s *rtspSession) onDecodeError(ctx *gortsplib.ServerHandlerOnDecodeErrorCtx) {
+	s.log(logger.Warn, "%v", ctx.Error)
+}