Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing Prometheus metrics "srt_conns_bytes_{received,sent}" #2620

Closed
rse opened this issue Nov 1, 2023 · 3 comments · Fixed by #2629
Closed

Add missing Prometheus metrics "srt_conns_bytes_{received,sent}" #2620

rse opened this issue Nov 1, 2023 · 3 comments · Fixed by #2629
Labels
enhancement New feature or request general

Comments

@rse
Copy link
Contributor

rse commented Nov 1, 2023

Describe the feature

MediaMTX provides Prometheus metrics for HLS, RTSP, RTMP and WebRTC, but unfortunately not for SRT. Could you please add the two missing metrics "srt_conns_bytes_received" and "srt_conns_bytes_sent"? Many thanks.
@rse rse mentioned this issue Nov 1, 2023
Closed
@rse
Copy link
Contributor Author

rse commented Nov 1, 2023

In the above referenced pull request I added the missing exporters.

rse added a commit to rse/FOREIGN-mediamtx that referenced this issue Nov 2, 2023
@rse
add missing Prometheus exports (bluenviron#2620, bluenviron#2619):
3192e25 
paths_bytes_sent, srt_conns, srt_conns_bytes_received, srt_conns_bytes_sent
rse added a commit to rse/FOREIGN-mediamtx that referenced this issue Nov 2, 2023
@rse
add missing Prometheus exports (bluenviron#2620, bluenviron#2619):
9222952 
paths_bytes_sent, srt_conns, srt_conns_bytes_received, srt_conns_bytes_sent
rse added a commit to rse/FOREIGN-mediamtx that referenced this issue Nov 2, 2023
@rse
add missing Prometheus exports (bluenviron#2620, bluenviron#2619):
4401b6a 
paths_bytes_sent, srt_conns, srt_conns_bytes_received, srt_conns_bytes_sent
@rse rse mentioned this issue Nov 2, 2023
Merged
rse added a commit to rse/FOREIGN-mediamtx that referenced this issue Nov 2, 2023
@rse
add missing Prometheus exports (bluenviron#2620, bluenviron#2619):
d9f9ebf 
paths_bytes_sent, srt_conns, srt_conns_bytes_received, srt_conns_bytes_sent
rse added a commit to rse/FOREIGN-mediamtx that referenced this issue Nov 2, 2023
@rse
add missing Prometheus exports (bluenviron#2620, bluenviron#2619):
2315c35 
paths_bytes_sent, srt_conns, srt_conns_bytes_received, srt_conns_bytes_sent
rse added a commit to rse/FOREIGN-mediamtx that referenced this issue Nov 2, 2023
@rse
add missing Prometheus exports (bluenviron#2620, bluenviron#2619):
5ad2d59 
paths_bytes_sent, srt_conns, srt_conns_bytes_received, srt_conns_bytes_sent
rse added a commit to rse/FOREIGN-mediamtx that referenced this issue Nov 2, 2023
@rse
add missing Prometheus exports (bluenviron#2620, bluenviron#2619):
dc0f0f3 
paths_bytes_sent, srt_conns, srt_conns_bytes_received, srt_conns_bytes_sent
@aler9 aler9 added enhancement New feature or request general labels Nov 2, 2023
rse added a commit to rse/FOREIGN-mediamtx that referenced this issue Nov 3, 2023
@rse
add missing Prometheus exports (bluenviron#2620, bluenviron#2619):
6bf70df 
paths_bytes_sent, srt_conns, srt_conns_bytes_received, srt_conns_bytes_sent
rse added a commit to rse/FOREIGN-mediamtx that referenced this issue Nov 4, 2023
@rse
add missing Prometheus exports (bluenviron#2620, bluenviron#2619):
e8c8189 
paths_bytes_sent, srt_conns, srt_conns_bytes_received, srt_conns_bytes_sent
rse added a commit to rse/FOREIGN-mediamtx that referenced this issue Nov 4, 2023
@rse
add missing Prometheus exports (bluenviron#2620, bluenviron#2619):
04aa21d 
paths_bytes_sent, srt_conns, srt_conns_bytes_received, srt_conns_bytes_sent
rse added a commit to rse/FOREIGN-mediamtx that referenced this issue Nov 5, 2023
@rse
add missing Prometheus exports (bluenviron#2620, bluenviron#2619):
9ca41b1 
paths_bytes_sent, srt_conns, srt_conns_bytes_received, srt_conns_bytes_sent
aler9 added a commit that referenced this issue Nov 8, 2023
@rse @aler9
metrics: add paths_bytes_sent, srt_conns, srt_conns_bytes_received, s…
4bf0d10 
…rt_conns_bytes_sent (#2620) (#2619) (#2629)

* add missing Prometheus exports (#2620, #2619):
paths_bytes_sent, srt_conns, srt_conns_bytes_received, srt_conns_bytes_sent

* protect Stream.BytesSent()

* add tests

---------

Co-authored-by: aler9 <46489434+aler9@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

This issue is mentioned in release v1.3.0 🚀
Check out the entire changelog by clicking here

@github-actions GitHub Actions
Copy link
Contributor

This issue is being locked automatically because it has been closed for more than 6 months.
Please open a new issue in case you encounter a similar problem.

@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request general
Projects
None yet
Milestone
No milestone
2 participants
@rse @aler9