Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLS stream not working with paths containing "/" #381

Closed
2 of 7 tasks
dorinclisu opened this issue May 18, 2021 · 3 comments
Closed
2 of 7 tasks

HLS stream not working with paths containing "/" #381

dorinclisu opened this issue May 18, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@dorinclisu
Copy link
Contributor

Which version are you using?

v0.16.0

Which operating system are you using?

OS

  • Linux
  • Windows
  • macOS

Architecture

  • amd64
  • arm64
  • arm7
  • arm6

Describe the issue

config.yaml

...
paths:
  test/path:
    source: rtsp://...
2021/05/18 17:02:03 I [0/0] rtsp-simple-server v0.16.0
2021/05/18 17:02:03 I [0/0] [RTSP] TCP listener opened on :8554
2021/05/18 17:02:03 I [0/0] [HLS] listener opened on :8888
2021/05/18 17:02:03 I [0/0] [path test/path] [rtsp source] started
2021/05/18 17:02:03 I [0/0] [path test/path] [rtsp source] ready
2021/05/18 17:02:08 I [0/0] [HLS] [conn 172.18.0.1:63864] GET /test/path
2021/05/18 17:02:08 I [0/0] [HLS] [converter test] opened
2021/05/18 17:02:08 I [0/0] [HLS] [converter test] ERR: unable to find a valid configuration for path 'test'
2021/05/18 17:02:08 I [0/0] [HLS] [converter test] closed

Slashes are perfectly legal characters for url paths, and it works fine with RTSP, but fails with HLS.

I suppose the reason is that the HLS converter / server does not properly handle nested directories for the stream fragment files.

Theoretically, as far as the server is concerned, it is easy to work around by replacing slashes with dashes for example, but from a system integration point of view it's a lot of work for me, to maintain backwards compatibility as the path is shared with RTSP.

Please let me know if it's possible to fix it, so I can wait for the upgrade, otherwise I will apply the workaround.

@aler9 aler9 added the bug Something isn't working label May 22, 2021
aler9 added a commit that referenced this issue May 29, 2021
@aler9
Copy link
Member

aler9 commented May 29, 2021

Thanks for reporting the issue, this is fixed in main and will be added to the next release.

@aler9
Copy link
Member

aler9 commented May 30, 2021

added to v0.16.2

@aler9 aler9 closed this as completed May 30, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2023

This issue is being locked automatically because it has been closed for more than 6 months.
Please open a new issue in case you encounter a similar problem.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants