Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All streams seen as idle in metrics #492

Closed
2 of 7 tasks
sshaikh opened this issue Aug 8, 2021 · 4 comments
Closed
2 of 7 tasks

All streams seen as idle in metrics #492

sshaikh opened this issue Aug 8, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@sshaikh
Copy link

sshaikh commented Aug 8, 2021

Which version are you using?

v0.17.0

Which operating system are you using?

OS

  • Linux
  • Windows
  • macOS

Architecture

  • amd64
  • arm64
  • arm7
  • arm6

Describe the issue

Metrics output always counts streams as idle, eg:

rtsp_clients{state="publishing"} 0 1628434566517
rtsp_clients{state="reading"} 24 1628434566517
rtsp_sources{type="rtsp",state="idle"} 8 1628434566517
rtsp_sources{type="rtsp",state="running"} 0 1628434566517
rtsp_sources{type="rtmp",state="idle"} 0 1628434566517
rtsp_sources{type="rtmp",state="running"} 0 1628434566517

In at least version 0.10.0, we would see running have value 8 instead.

Describe how to replicate the issue

Activate metrics with metrics: yes and check http://localhost:9998/metrics for output.

@aler9 aler9 added the bug Something isn't working label Aug 9, 2021
@aler9
Copy link
Member

aler9 commented Aug 12, 2021

metrics have been rewritten to provide more data. Tests have been added in order to make sure that returned data is correct.

@aler9
Copy link
Member

aler9 commented Aug 12, 2021

added in v0.17.1. Metrics documentation is available in the README.

@aler9 aler9 closed this as completed Aug 12, 2021
@sshaikh
Copy link
Author

sshaikh commented Aug 12, 2021

The new metrics are much more useful, although I may suggest renaming them to include your domain (eg paths looks ripe for a conflict).

Many thanks.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2023

This issue is being locked automatically because it has been closed for more than 6 months.
Please open a new issue in case you encounter a similar problem.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants