Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

produce same absolute time in RTSP and HLS #1249

Merged
merged 1 commit into from Nov 28, 2022
Merged

produce same absolute time in RTSP and HLS #1249

merged 1 commit into from Nov 28, 2022

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Nov 17, 2022

  • add a NTP timestamp field to each data unit
  • use that NTP timestamp in all protocols

* add a NTP timestamp to each data unit
* use that NTP timestamp in all protocols
@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2022

Codecov Report

Merging #1249 (b5b6868) into main (282d155) will decrease coverage by 0.06%.
The diff coverage is 72.22%.

@@            Coverage Diff             @@
##             main    #1249      +/-   ##
==========================================
- Coverage   67.51%   67.44%   -0.07%     
==========================================
  Files         107      107              
  Lines        8917     8939      +22     
==========================================
+ Hits         6020     6029       +9     
- Misses       2327     2340      +13     
  Partials      570      570              
Impacted Files Coverage Δ
internal/core/hls_muxer.go 58.88% <0.00%> (ø)
internal/core/rpicamera_source.go 0.00% <0.00%> (ø)
internal/core/data.go 33.33% <33.33%> (ø)
internal/core/rtmp_conn.go 64.96% <33.33%> (-0.24%) ⬇️
internal/core/rtsp_session.go 64.95% <33.33%> (-0.42%) ⬇️
internal/core/rtsp_source.go 70.37% <33.33%> (-1.06%) ⬇️
internal/core/hls_source.go 71.42% <50.00%> (-0.64%) ⬇️
internal/core/rtmp_source.go 71.30% <50.00%> (-0.38%) ⬇️
internal/core/stream.go 92.85% <100.00%> (ø)
internal/hls/muxer.go 76.74% <100.00%> (ø)
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aler9 aler9 merged commit e605727 into main Nov 28, 2022
@aler9 aler9 deleted the ntp branch November 28, 2022 08:00
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants