Supports webrtc interface filtering on server #2460
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For security and ICE optimization purposes, it would be good to add the ability to restrict ICE candidates on the server based on the network interfaces available. This is a common feature for WebRTC servers.
Usage:
Added a webrtcICEInterfaces interface to the mediamtx.yml under webrtc.
webrtcICEInterfaces takes in a string array of the network interfaces available on the server for ICE candidate resolution to happen.
eg:
webrtcICEInterfaces: [ "eno1", "enp2s0"]
The string array is then applied on the SetInterfaceFilter method in pion.
//https://pkg.go.dev/github.com/pion/webrtc/v3#SettingEngine.SetInterfaceFilter