api: return 500 instead of 404 in case of non-existing items

[aler9]

This is needed to differentiate between calls to non-existent andpoints and calls to valid endpoints, but with an ID pointing to a non-existing item, and to return JSON in the latter case.

[codecov]

Codecov Report

Merging #2582 (ccc70a1) into main (6af27fd) will increase coverage by 0.21%.
The diff coverage is 96.42%.

@@            Coverage Diff             @@
##             main    #2582      +/-   ##
==========================================
+ Coverage   59.60%   59.81%   +0.21%     
==========================================
  Files         145      145              
  Lines       15528    15520       -8     
==========================================
+ Hits         9255     9284      +29     
+ Misses       5620     5593      -27     
+ Partials      653      643      -10     

Files	Coverage Δ
internal/core/hls_manager.go	94.56% <100.00%> (+1.08%)	⬆️
internal/core/path_manager.go	89.92% <100.00%> (ø)
internal/core/rtmp_server.go	88.58% <100.00%> (+1.63%)	⬆️
internal/core/rtsp_server.go	87.01% <100.00%> (+1.05%)	⬆️
internal/core/srt_server.go	89.83% <100.00%> (+1.69%)	⬆️
internal/core/webrtc_manager.go	64.64% <100.00%> (+0.95%)	⬆️
internal/core/api.go	66.20% <94.11%> (+3.19%)	⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[tbnguyen1407]

Hello, just a suggestion to intead use

• 501: for unknown/unmapped route (where we are not aware of the requested resource)
• 404: for non-existent resources (where we are aware of the resource but cannot find it)

Since 404 is very common for standard CRUD APIs, using 500 code for it seems a bit weird and we must deserialize the body and check for a hardcoded string to know if it is not found or other error.

I also found the code is inconsistent for DELETE/PATCH, which currently return 400 for non-existent path.

[aler9]

@tbnguyen1407 i fixed it in #2920

[github-actions]

This issue is mentioned in release v1.5.0 🚀
Check out the entire changelog by clicking here