webrtc: add options (width, height, framerate, audio capture) and store parameters in URL (#1837) (#2167)

[Lukinoh]

Ciao,

For my personal needs, I wanted to add the audio capture feature, but I ended up adding other features, namely (#1837) (#2167).

I added these new options:

• video width
• video height
• video ideal framerate
• audio capture

And I implemented the feature to store the options in the URL.

I also did a bit of refactoring:

• Improve alignment of the form
• Reduce redundancy of document.getElementById for the different inputs in the form
• Use only once new URL(window.location.href)

[codecov]

Codecov Report

Merging #2584 (815e394) into main (cde1909) will increase coverage by 0.22%.
Report is 15 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2584      +/-   ##
==========================================
+ Coverage   59.85%   60.08%   +0.22%     
==========================================
  Files         145      145              
  Lines       15530    15536       +6     
==========================================
+ Hits         9296     9335      +39     
+ Misses       5591     5564      -27     
+ Partials      643      637       -6     

see 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[aler9]

Hello, i've tested the PR and it performs its job. Alignment, linting and tabs are not perfect but that's not a problem, it will be handled in the future when a JS linter (and maybe a JS compiler) will be added to the building process.

For clarity, remove the "capture audio" switch and edit the page in order to always try to capture audio when sharing the screen. The label "capture audio" can cause confusion, the feature is available only in some browsers and, in case it's available, there's already a big switch in the screen capture dialog that opens shortly after.

[Lukinoh]

Thank you for the feedback.

I improved a bit the alignment of the (visual) form.

Concerning the audio capture, I totally agree with you.
My first plan was to simply set it to true, but as it was explicitely set to false, I was unsure if it was deliberately done as such or not. So I added the toggle.

[aler9]

merged, thanks!

[github-actions]

This issue is mentioned in release v1.3.0 🚀
Check out the entire changelog by clicking here