Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand host env vars #3044

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Expand host env vars #3044

merged 1 commit into from
Feb 19, 2024

Conversation

dbason
Copy link
Contributor

@dbason dbason commented Feb 19, 2024

Expand environment vars from the underlying host in the command.

The specific usecase this will solve for us is publishing the hostname to an etcd store on ready which will allow naive horizontal scalability.

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (34dbcfb) 55.26% compared to head (9e13e22) 55.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3044      +/-   ##
==========================================
- Coverage   55.26%   55.26%   -0.01%     
==========================================
  Files         143      143              
  Lines       15414    15414              
==========================================
- Hits         8519     8518       -1     
- Misses       6217     6218       +1     
  Partials      678      678              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit e8b19b8 into bluenviron:main Feb 19, 2024
7 of 8 checks passed
@aler9
Copy link
Member

aler9 commented Feb 19, 2024

os.Expand() is a nice catch. Merged, thanks!

@tmatth
Copy link
Contributor

tmatth commented Feb 19, 2024

Thanks for this, this effectively solves a long standing issue for us that we had to patch around (previously discussed here: #828)

Copy link
Contributor

github-actions bot commented Mar 4, 2024

This issue is mentioned in release v1.6.0 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants