Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playback: improve performance when reading big segments #3209

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Apr 8, 2024

No description provided.

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 55.76%. Comparing base (9ce12ff) to head (02b0f1d).
Report is 1 commits behind head on main.

Files Patch % Lines
internal/playback/segment_fmp4.go 66.66% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3209      +/-   ##
==========================================
+ Coverage   55.74%   55.76%   +0.01%     
==========================================
  Files         154      154              
  Lines       16941    16953      +12     
==========================================
+ Hits         9444     9454      +10     
- Misses       6751     6752       +1     
- Partials      746      747       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit b5b44f4 into main Apr 8, 2024
8 checks passed
@aler9 aler9 deleted the fix/playback-speed branch April 8, 2024 19:35
Copy link
Contributor

This issue is mentioned in release v1.7.0 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant