Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrtc: return 404 in case a WHIP PATCH or WHIP DELETE request fails #3232

Merged
merged 1 commit into from
Apr 13, 2024

webrtc: return 404 in case a WHIP PATCH or WHIP DELETE request fails

c661d59
Select commit
Loading
Failed to load commit list.
Merged

webrtc: return 404 in case a WHIP PATCH or WHIP DELETE request fails #3232

webrtc: return 404 in case a WHIP PATCH or WHIP DELETE request fails
c661d59
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 13, 2024 in 1s

56.08% (+0.07%) compared to 4354535

View this Pull Request on Codecov

56.08% (+0.07%) compared to 4354535

Details

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 56.08%. Comparing base (4354535) to head (c661d59).

Files Patch % Lines
internal/servers/webrtc/http_server.go 40.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3232      +/-   ##
==========================================
+ Coverage   56.01%   56.08%   +0.07%     
==========================================
  Files         154      154              
  Lines       17036    17042       +6     
==========================================
+ Hits         9542     9558      +16     
+ Misses       6741     6734       -7     
+ Partials      753      750       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.