Create "click" event using an event constructor #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way the click event was being created is deprecated. An event constructor should be used instead: https://developer.mozilla.org/en-US/docs/Web/Guide/DOM/Events/Creating_and_triggering_events In addition using the event constructor fixes a scrolling bug where clicking the "OK" button in the modal caused a scroll to the top of the page.
|
Thanks for your pull request! I'll give it a test run soon and release a new version. Shoudn't we change line 56 for this too? It now checks for something that isn't used. |
rvanlieshout
added a commit
that referenced
this pull request
Oct 11, 2013
Create "click" event using an event constructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way the click event was being created is deprecated. An event constructor should be used instead:
https://developer.mozilla.org/en-US/docs/Web/Guide/DOM/Events/Creating_and_triggering_events
In addition using the event constructor fixes a scrolling bug where clicking the "OK" button in the
modal caused a scroll to the top of the page.