Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bootloader date format #1551

Merged
merged 3 commits into from Mar 21, 2023

Conversation

patrickelectric
Copy link
Member

@patrickelectric patrickelectric commented Mar 21, 2023

image
Fix #1550

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Fix bluerobotics#1550

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@patrickelectric patrickelectric changed the title Fix date vl085 Fix bootloader date format Mar 21, 2023
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still looks very strange.
It starts with date, then theres time, then there's date again (year).

@patrickelectric
Copy link
Member Author

It still looks very strange. It starts with date, then theres time, then there's date again (year).

I'm not sure if I follow, can you be more explicit ?
This fix the current format that's broken, where it only shows until the first :

@rafaellehmkuhl
Copy link
Member

It still looks very strange. It starts with date, then theres time, then there's date again (year).

I'm not sure if I follow, can you be more explicit ? This fix the current format that's broken, where it only shows until the first :

Previously, the output was incomplete, but it was just a date, so not confusing.

Right now the output is "day-of-the-week day month hour:minute timezone year (epoch)".

We should have something more straightforward like "day-of-the-week day month yeart timezone hour:minute (epoch)"

…r firmware and bootloader

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@patrickelectric
Copy link
Member Author

@rafaellehmkuhl check the latest version

@patrickelectric patrickelectric merged commit e332140 into bluerobotics:master Mar 21, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bootloader version is not formatted correctly
2 participants