Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: camera-manager: add "Disable MAVLink" option #1010

Closed
1 task done
ES-Alexander opened this issue May 12, 2022 · 1 comment · Fixed by #1825
Closed
1 task done

core: camera-manager: add "Disable MAVLink" option #1010

ES-Alexander opened this issue May 12, 2022 · 1 comment · Fixed by #1825
Labels
core Issue related to BlueOS-core enhancement New feature or request needs-external-change Depends on 3rd party tools ui User Interface feature

Comments

@ES-Alexander
Copy link
Collaborator

ES-Alexander commented May 12, 2022

Current behaviour

Currently every detected camera is presented by BlueOS via MAVLink, but users may wish for some (or all) connected camera streams to only be presented via non-MAVLink-enabled applications.

This forum post brings up one such use-case, which is compounded by QGroundControl automatically streaming at least one MAVLink-enabled stream (if one is available), which then prevents other applications from accessing that stream. Presumably a workaround would be to add a second stream endpoint for a camera, but that seems both unnecessary and unintuitive to need to do, and may be difficult to manage which endpoint is being used for/via MAVLink.

Edit: an additional workaround would be to ensure any external streams are connected to before a MAVLink-camera-enabled application is opened, which avoids adding unnecessary redundancy but is still not intuitive or user-friendly.

Expected or desired behaviour

In order of preference

  1. A "Disable MAVLink" option per endpoint of each camera
    • neat/intuitive UI may be tricky, but this is the best for functionality
    • preferably something like a checkbox beside each endpoint, but effective labelling may be tricky
    • if necessary could even be added in the "Extra configuration" dropdown as an input for a comma-separated list of indices
  2. A "Disable MAVLink" checkbox per camera
    • e.g. in the existing "Extra configuration" dropdown
  3. A "Disable MAVLink" checkbox for the entire camera manager
    • seems much less versatile than the alternatives, but would at least solve the use-case in the forum post

This is advanced configuration, so should only be available in Pirate mode.

Prerequisites

  • I have checked to make sure that a similar request has not already been filed or fixed.
@ES-Alexander ES-Alexander added enhancement New feature or request core Issue related to BlueOS-core ui User Interface feature triage Needs triage from developers labels May 12, 2022
@ES-Alexander
Copy link
Collaborator Author

@joaoantoniocardoso has mentioned that

another workaround, if no video streams are being used on qgc, is to start mavlink-camera-manager with an unreachable mavlink ip/port. ... it can be done inside the terminal, by killing (ctrl+c) the mavlink-camera-manager on the video terminal, and then starting it again but changing the ip address to something unreachable like 127.1.1.1

That approach avoids configuration of the topside computer, and of the stream, but I'm not sure if it would be persistent across restarts. That may require changing the default port or IP in a file somewhere, which could potentially be ill-advised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issue related to BlueOS-core enhancement New feature or request needs-external-change Depends on 3rd party tools ui User Interface feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants