Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oversampling setting adjustment #10

Open
jaxxzer opened this issue Jan 30, 2019 · 6 comments
Open

Add oversampling setting adjustment #10

jaxxzer opened this issue Jan 30, 2019 · 6 comments

Comments

@jaxxzer
Copy link
Member

jaxxzer commented Jan 30, 2019

This will allow us to reduce the blocking measurement delay time.

@jaxxzer
Copy link
Member Author

jaxxzer commented Jan 30, 2019

For example, our python library already supports this: https://github.com/bluerobotics/ms5837-python#readoversamplingosr_8192

@senceryazici
Copy link

Absolutely, right now we're having issues using our bar30 sensor, as the sensor spends time of 40ms to read, it reduces our communication rate down to ~50Hz,

since the oversampling can be set to 256, it can be running at 1.5Khz.
Please implement this feature to the arduino library.

Thanks

@senceryazici
Copy link

I've modified such changes on my forked repository. => https://github.com/senceryazici/BlueRobotics_MS5837_Library/tree/pr_osr_implementation

I can open a pull request if you like.

Thanks

@jaxxzer
Copy link
Member Author

jaxxzer commented May 13, 2019

I can open a pull request if you like.

@senceryazici yes please 👍

@senceryazici
Copy link

senceryazici commented May 14, 2019

Pending pull request #16

@kiteborne
Copy link

Why does it not compile on teensy 3.2 ? - is it some of the math in the library (POW) forexample ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants