Refactor expenses controller #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the Rails Antipattern chapter on "Rats Nest Resources" as a guide, this separates out what used to be the ExpensesController into two new controllers: ExpensesController -- for unscoped expenses User::ExpensesController -- for expenses scoped to current_user It also moves the feature specs and model files to mirror this layout.
| end | ||
|
|
||
| def expense_params | ||
| params.require(:expense).permit(:date, :category_id, :description, :currency, :amount) |
There was a problem hiding this comment.
Line is too long. [90/80]
|
Changes Unknown when pulling 834cce9 on refactor_controller into * on master*. |
|
Changes Unknown when pulling 834cce9 on refactor_controller into * on master*. |
|
Changes Unknown when pulling 834cce9 on refactor_controller into * on master*. |
|
Changes Unknown when pulling bee348d on refactor_controller into * on master*. |
| class User | ||
| class ExpensesDatatable | ||
| include DatatablesHelper | ||
| delegate :params, :link_to, :fa_icon, :number_with_precision, to: :view_context |
There was a problem hiding this comment.
Line is too long. [83/80]
|
Changes Unknown when pulling 38061a7 on refactor_controller into * on master*. |
bluerogue251
added a commit
that referenced
this pull request
Sep 4, 2014
Refactor expenses controller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the Rails Antipattern chapter on "Rats Nest Resources" as a guide,
this separates out what used to be the ExpensesController into two new
controllers:
ExpensesController -- for unscoped expenses
User::ExpensesController -- for expenses scoped to current_user
It also moves the feature specs and model files to mirror this layout.