Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Filename encoding problems #43

Closed
kutu opened this issue Jun 16, 2022 · 12 comments
Closed

[Bug] Filename encoding problems #43

kutu opened this issue Jun 16, 2022 · 12 comments

Comments

@kutu
Copy link

kutu commented Jun 16, 2022

Tacent won't open file if it has Cyrillic letter (it opens with blank window).
try rename a file to ы.png

Tacent title bar incorrectly display filenames with chars that not English.
image

@bluescan
Copy link
Owner

bluescan commented Jun 18, 2022

KubuntuCyrillic_Screenshot_20220618_134124
From Kubuntu

@bluescan
Copy link
Owner

bluescan commented Jun 18, 2022

image
This one's from Windows 11.

@kutu
Copy link
Author

kutu commented Jun 18, 2022

i use windows 10
did you use precompiled version?
i use tacent v1.0.27

if i open image with double click, it just blank
if i try drag and drop image, tacent opens next image in folder

@bluescan
Copy link
Owner

Note, the 2 screens above are without making any changes/fixes... so might need some more information. It is worth noting that in windows I do have the following option set (as I needed utf-8 to show u properly in console output):

image

@bluescan
Copy link
Owner

I'll try the release of 1.0.27. I don't have windows 10 tho.

@bluescan
Copy link
Owner

bluescan commented Jun 18, 2022

Works locally with the released 1.0.27. Also tried double-clicking and drag-and-drop without issue. I'll need to try (but can't right now) with the checkbox above un-checked. glfw expects the title in utf-8 encoding which is what is being passed.

@kutu
Copy link
Author

kutu commented Jun 19, 2022

after enabling "beta" option, it started to work as expected

@bluescan
Copy link
Owner

Yeah. Hopefully you're happy with this for now (as a bonus, you can now see more unicode characters in the command prompt etc). In truth you should not really need to have this option checked if the viewer and its base libraries were calling the UNICODE and _UNICODE versions (UTF16 on windows) OS calls everywhere... It's a bit of work to fix, but I'll leave this issue open for now. Thanks for the report.

@bluescan
Copy link
Owner

As of 03e7cb4 the Beta flag is no longer necessary.

@kutu
Copy link
Author

kutu commented Jan 2, 2024

  • file name in title is showing correctly

  • drag and drop image to tacentview is working

  • double click on file with Cyrillic symbols is still not working (I'm not using "Beta" flag). It opens next file in folder. Accidentally if there is only one file in folder, then it opens file that I wanted

using tacentview_1.0.43.zip

@bluescan
Copy link
Owner

bluescan commented Jan 9, 2024

Hi kutu. Thanks for the report. I'll re-open this. Looks like it's 'nearly' all working ;)

@bluescan bluescan reopened this Jan 9, 2024
@bluescan
Copy link
Owner

bluescan commented Jan 9, 2024

Fixed in 6006aa0
'Beta' checkbox no longer necessary to have the viewer open files with cyrillic characters by double-clicking.

@bluescan bluescan closed this as completed Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants