Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Python3 Support #107

Merged
merged 9 commits into from
Dec 29, 2019
Merged

Python3 Support #107

merged 9 commits into from
Dec 29, 2019

Conversation

smellman
Copy link
Contributor

Fixes for supports Python3.

  • includes fixes from Python3 compatibility #71
  • docker container uses pip3
  • fixes with scope in test code for Python3
  • fixes decode issue

@claassistantio
Copy link

claassistantio commented Dec 20, 2019

CLA assistant check
All committers have signed the CLA.

@claassistantio
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@smellman
Copy link
Contributor Author

@jaygorrell Can you review my PR?

Copy link
Contributor

@jaygorrell jaygorrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@chrisgilmerproj
Copy link
Collaborator

@jaygorrell - should we tag this as v2.0.0 and start doing releases? It might actually help us in the future to have these tags for folks doing development.

@jaygorrell
Copy link
Contributor

I think so, yeah - feel free to push that if you have a moment.

@chrisgilmerproj
Copy link
Collaborator

Done!

@chrisgilmerproj
Copy link
Collaborator

I tested this against #100 and was able to prove everything worked with make scan and make update. Nice job @smellman!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants