-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3rd party labeler lexicons rework #2040
Conversation
On re-using profile metadata: de-duping is nice, but it would also make sense to me to have all of avatar, displayName, and description on the service record. I don't have a specific example but it seems pretty feasible to me that you'd want different types of name/description in the two contexts. Feels like we could start with all-profile and add more fields though, while the other direction might be tricky. I'm also just now realizing that, in contrast to feed gens, mod services will have a handle! That is actually pretty nice to be able to hook in to domain verification. 👍 to namespace move and calling them "service". 👍 to embedding the full record, with at-uri and cid as parallel fields. It feels like the service record could get pretty big if there are a bunch of long-description policies. Eg, will we put our full community guidelines in there... i'm guessing not to start, we would link from description? Each policy could be a separate record. A related thing is translating policies, so having the (human) language indicated, or an array or map or something. Some mod services might be lang specific, but something like a visual nudity labeled can apply to multiple languages and would want to describe policy. This is a whole can of worms though, AFAIK we don't have a "translated text" thing to just copy. Maybe we just make the per-policy field shorted and enable/encourage linking out to an external URL for the full policy, and leave translation up to that? |
From a parallel discussion: we could consider calling it |
Yeah this is all looking great. Two things that just came up while Eric and I were just looking at this:
|
Something else we need to do: replace all the usages of labeler with modservice or mod. |
Rework some of the lexicons around labelers.
A few notes:
app.bsky.moderation
namespaceapp.bsky.moderation.service
lexicon has a key type ofliteral:self
did
property from recordgetActorLabelers
displayName
andavatar
have been removed (and will just fall back to the repo's profile)modServiceViewDetailed
so that it returns the actual record rather than the properties recomposed onto the view