relax restriction on handle length in PDS

[itaru2622]

fix #2391

[itaru2622]

the code followed the discussion in the issue #2391.

[bnewbold]

@itaru2622 this is simple and resolves a long-standing issue for self-hosted PDS operators. thanks!

could you add a couple additional tests to handle-validation.test.ts, for this new logic?

for example, a longer base domain in the domains list, and an example of a less-than-18-char handle working with that (even if longer than 30 total chars), and a ~20 char handle on the .test domain (which would be less than 30 chars total, but still invalid). you'd have to add a helper for "expectNotThrow" or similar I think.

if you have trouble adding these LMK and I an take a pass at it.

[itaru2622]

@bnewbold test case added in handle-validation.test.ts

I hope below tests meet your request. please refer the code for detail.

    expectThrow('usernamepartover18c.test',    'Handle too long')                                                                                                        
    expectNotThrow('u23456789012345678.test',  'safe up to 18 chars in first segment of the handle')                                                                     
    expectThrow('usernamepartover18c.loooooooooooooooooong-pds-over18chars.mybsky.mydomain.com',   'Handle too long')                                                    
    expectNotThrow('u23456789012345678.loooooooooooooooooong-pds-over18chars.mybsky.mydomain.com', 'safe long domain in the handle')

[dholms]

Sweet this looks good 👍

Thanks for the tests as well

[bnewbold]

Two CI test issues:

• lint issues with the new test code
• many of the example handles in pds/tests/seeds/users-bulk.ts have become invalid and need to be updated; this impacts tests in other packages that use those accounts

I can try to resolve both of these from a new branch, and will update this PR when I get around to that.

[bnewbold]

I can't update this PR (the branch is in a different repo), but I created this new PR on top of it, which resolves the build issues: #2392

[bnewbold]

@itaru2622 I merged the above-linked PR, which included your commits. I'm going to close this PR now.

It may take us a while to update the PDS "distribution".

[itaru2622]

@bnewbold thank you for your work on this PR and fixing.

I confirmed my codes were merged into latest main branch.
so, I will close this PR.

[itaru2622]

This PR has been taken over by #2410 and has been merged into main branch, so this PR is closed.