Update legacy blob refs in profile records #2488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinivy
reviewed
May 14, 2024
devinivy
reviewed
May 14, 2024
devinivy
reviewed
May 14, 2024
| record: ProfileRecord, | ||
| ) => { | ||
| if (record.avatar && !record.avatar.original['$type']) { | ||
| const blob = await actorStore.repo.blob.getBlobMetadata(record.avatar.ref) |
There was a problem hiding this comment.
Just double-checking that we like the behavior of throwing here if the blob is not found.
There was a problem hiding this comment.
Yup think so
I believe that's the behavior we'd do you tried to update a record and were missing a blob anyways 👍
devinivy
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a relatively crude/ham-fisted fix intended to help with the fact that some accounts still have legacy blob refs in their profile records which is preventing them from updating their profile record.
Ended up landing this in
putRecordinstead of theprepareWritefunctions because we need access to the actor store to find thesizeof the blob. We only implement it inputRecordwhen updating specifically a profile record in order to both reduce the number of checks we're required to do, but also because this issue is mostly isolated to historical profile records.This is a stopgap until we have time to run a proper migration that updates all legacy blob refs.