Lexicon: declaration, assertion/confirmation, follow app migration #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dholms
reviewed
Mar 15, 2023
| validate: false, | ||
| }) | ||
| } catch { | ||
| const del = prepareDelete({ |
There was a problem hiding this comment.
just curious, how many hit this in trial runs?
There was a problem hiding this comment.
There were 7, I think. I looked at them all and they were indeed malformed in some way (either a handle rather than a did, or empty did).
dholms
approved these changes
Mar 15, 2023
dholms
reviewed
Mar 15, 2023
| // Should be 4-5k records | ||
| const recordsToDelete = await tx.db | ||
| .selectFrom('record') | ||
| .innerJoin('repo_root', 'repo_root.did', 'record.did') // Ignore any records not in a repo |
There was a problem hiding this comment.
did you encounter any of these in your tests?
There was a problem hiding this comment.
I didn't check actually, but I could do a run without this and find out.
There was a problem hiding this comment.
Okay this was overly paranoid, it just doesn't happen on any environment 😆 Will remove.
dholms
reviewed
Mar 15, 2023
| }), | ||
| ) | ||
|
|
||
| await repoTx.processWrites(did, updates, now) |
There was a problem hiding this comment.
ah probably wanna ensure updates.length > 0
|
@dholms should be good for another look! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two app migrations contained here:
subjectis a did rather than an actor ref. Invalid follow records are deleted.In both we use the repo service, which takes care of updating repositories plus the generic
recordindex. If any app-view related changes are needed, those are handled at the end of the migrations— that would include updates toduplicate_recordandfollowtables. A no-opmessageDispatcheris used rather than a real one in order to avoid app-view indexing logic from kicking in.