Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lexicon: app migration to tidy notifications #733

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Lexicon: app migration to tidy notifications #733

merged 1 commit into from
Mar 29, 2023

Conversation

devinivy
Copy link
Collaborator

Three things going on here:

  • Remove notifications for trends and assertions (i.e. old scene notifs).
  • Update record uris in notifications for the change from votes to likes.
  • Update record cids in notifications for likes and follows.

dholms
dholms approved these changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@dholms dholms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks excellent 👍

@devinivy devinivy merged commit 833c06e into lex-refactor Mar 29, 2023
@devinivy devinivy deleted the lex/fix-vote-to-like-notifs branch March 29, 2023 19:43
This was referenced Mar 29, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dholms dholms dholms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@devinivy @dholms