hepa: periodically refresh auth session #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnewbold
force-pushed
the
bnewbold/hepa-auth-refesh
branch
from
cec6363
to
89d85b5
Compare
bnewbold
force-pushed
the
bnewbold/hepa-auth-refesh
branch
from
89d85b5
to
cfbe117
Compare
|
I'm going to merge this as well, to get out a deploy on top of the context refactor. This PR is really just a hack around |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around a current issue in prod where actions are failing to persist because the session expires.
The real fix for the underlying issue (IMHO) is to re-implement
xrpc.Clientto handle this in a more elegant and robust way. That is sort-of tracked in #378I was initially confused why this was only coming up when taking actions, because the client is used for a number of reads (GET) as well. Those GETs mostly use admin auth (a token in the HTTP Authorization header), not login/session auth (which requires refresh), which explains why it mostly works, then fails for actions.