UI/UX improvements in Edit profile screen #1767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since react-native-reanimated is not configured for web support (https://docs.swmansion.com/react-native-reanimated/docs/2.x/fundamentals/web-support/), we are enabling fade out animation for iOS and android solely
tarikfp
changed the title
pfrazee
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
EditProfilescreen to the bottom direction, there will be a cropped area as can be seen in the video below:Screen.Recording.2023-10-28.at.22.53.17.mov
EditProfilescreen.Screen.Recording.2023-10-28.at.23.40.51.mov
Fixes
flex:1toKeyboardAvoidingViewcomponent. There will not be any cropped area at the bottom of the screen.Screen.Recording.2023-10-29.at.00.08.31.mov
Cancelbutton inEditProfilescreen when there is an ongoing process. Alternatively, we can utilizereact-native-reanimated'sFadeOutanimation for native platform. Since,react-native-reanimatedis not configured for web yet.Screen.Recording.2023-10-29.at.00.10.31.mov