Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle-change modal with custom domain support #273

Merged
merged 4 commits into from Mar 7, 2023
Merged

Handle-change modal with custom domain support #273

merged 4 commits into from Mar 7, 2023

Conversation

pfrazee
Copy link
Collaborator

@pfrazee pfrazee commented Mar 7, 2023

Closes #65

  • Adds a "change handle" modal with support for custom domains
  • Updates the look & feel of the settings page based on Fons' mockups
  • Adds a tool to remove accounts from the switcher
  • Updates signin to work with custom domains
New Settings Modal state 1 Modal state 2
image image image

@pfrazee
Dont append the server's domain name when a custom domain is used
e89611b
@pfrazee
Update the settings look & feel and add a tool to remove accounts fro…
b115ab0 
…m the switcher
@pfrazee
Try not rendering the bottomsheet when no modal is active.
699bccb 
There are cases where the bottomsheet decides to show itself when
it's not supposed to. It seems obvious to do what this change is
doing -- just dont render bottomsheet if no modal is active -- but
previously we experienced issues with that approach. This time it
seems to be working, so we're gonna yolo try it.
@pfrazee
Implement a handle-change modal with support for custom domains (closes
2320f22 
#65)
@pfrazee
Copy link
Collaborator Author

pfrazee commented Mar 7, 2023

This is ready to go, but we should do a pass on error messages from the server. Right now it gives a 500 if the resolve or update call experiences a DNS failure, and we want it to give something useful.

@pfrazee pfrazee merged commit 1044c8b into main Mar 7, 2023
@pfrazee pfrazee deleted the 65-dns branch March 7, 2023 03:37
pfrazee added a commit that referenced this pull request Apr 3, 2023
@pfrazee
Handle-change modal with custom domain support (#273)
2f3fc4f 
* Dont append the server's domain name when a custom domain is used

* Update the settings look & feel and add a tool to remove accounts from the switcher

* Try not rendering the bottomsheet when no modal is active.

There are cases where the bottomsheet decides to show itself when
it's not supposed to. It seems obvious to do what this change is
doing -- just dont render bottomsheet if no modal is active -- but
previously we experienced issues with that approach. This time it
seems to be working, so we're gonna yolo try it.

* Implement a handle-change modal with support for custom domains (closes #65)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DNS username flow
1 participant
@pfrazee