[APP-703] Android horizontal scroll registers as tap #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pfrazee I think this PR can be merged after testing. I can add the two other features in later PRs as they require a lot more work and performance monitoring/debugging. |
|
Holy moly I had to try ten times to get my iphone to run the build and I'm glad I did This breaks the post controls on iOS |
|
RNGH workaround did not work |
pfrazee
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a lot of investigation, it seems as though this issue is caused due to using
Touchablesfrom core react-native instead of RNGHdohooo/react-native-reanimated-carousel#150 (comment)
I have replaced them with the ones from RNGH in the
<Link>component. However, this component is used in a lot of places so extensive testing is required as theTouchablesfrom RNGH are not a drop-in replacement.There are a couple more optimizations that can be done along the same vein (although, they don't have to be part of this PR):
onPressIn)PostThreadscreen on Android. This is very slow, and that is why sometimes the taps register after the horizontal scroll, which is a bad experience for Android users