Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review use of kind kwarg #196

Merged
merged 1 commit into from
Aug 24, 2021
Merged

review use of kind kwarg #196

merged 1 commit into from
Aug 24, 2021

Conversation

prjemian
Copy link
Contributor

FIX #61

@prjemian prjemian added the task label Aug 24, 2021
@prjemian prjemian added this to the v1.0.0 milestone Aug 24, 2021
@prjemian prjemian requested a review from mrakitin August 24, 2021 18:15
@prjemian prjemian self-assigned this Aug 24, 2021
@prjemian prjemian added this to In progress in v1.0.0 release via automation Aug 24, 2021
@prjemian
Copy link
Contributor Author

@mrakitin What else needs to be done?

Would you agree that the real positioners should be kind="normal" while the pseudo positioners should be kind="hinted"? (per comment in PR #52)

mrakitin
mrakitin approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I think it makes sense to hint h, k, and l.

@prjemian
Copy link
Contributor Author

@mrakitin Thanks!

@prjemian prjemian merged commit cfb7227 into main Aug 24, 2021
@prjemian prjemian deleted the 61-hinting branch August 24, 2021 22:07
v1.0.0 release automation moved this from In progress to Done Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrakitin mrakitin mrakitin approved these changes

Assignees

@prjemian prjemian

Labels
task
Projects
No open projects
v1.0.0 release
  
Done
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

check Component hinting in the examples
2 participants
@prjemian @mrakitin