-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add energy features to Diffractometer base class #44
Conversation
This is marked as draft since the examples in the documentation need to be revised to use the new code additions. |
@jklynch @MikeHart85 @mrakitin Might need to build the documentation to review |
@ambarb, @stuartcampbell, @stuwilkins, @gfabbris : Can you review this PR? |
@jklynch @MikeHart85 @mrakitin Can you review please? See PDF (above) for build documentation. |
@prjemian Will look at this today. |
I'm ready to merge this today if there are no objections. |
@prjemian I had a quick look this morning and most of the changes look like ones we discussed as you were developing other things. Just wanted to follow up and say that some of these changes are really exciting (particularly locking on beam line E and using the EGU pv so people can drive the beamline as they are accustomed (eV or keV). |
As requested, fixes #43 .
In #25, #26, and #42, an example was prepared to show how to connect energy from the local controls with the calc engine energy. The additional features were:
@ambarb, @stuartcampbell, @stuwilkins, @gfabbris : Your comments and suggestions are welcome.