Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context for callback to be removed from sim signal #49

Closed
DominicOram opened this issue Nov 1, 2023 · 4 comments · May be fixed by #51
Closed

Add context for callback to be removed from sim signal #49

DominicOram opened this issue Nov 1, 2023 · 4 comments · May be fixed by #51

Comments

@DominicOram
Copy link
Contributor

DominicOram commented Nov 1, 2023

When writing tests I want to simulate some basic signal behaviour e.g. writing to one signal will put to another. However, I would like to make sure this behaviour is properly cleaned up between tests. I can simulate with set_sim_callback and set_sim_value but there is no way to remove this callback.

Acceptance Criteria

  • There is a context that removes callbacks from simulated signals on cleanup
@DominicOram DominicOram self-assigned this Nov 1, 2023
@DominicOram DominicOram changed the title Add function for callback to be removed from sim signal Add context for callback to be removed from sim signal Nov 1, 2023
@coretl
Copy link
Collaborator

coretl commented Nov 2, 2023

I like this being a context, then making it fire on put rather than on every update, as that is what the tests want

@DominicOram DominicOram removed their assignment Nov 2, 2023
@DominicOram
Copy link
Contributor Author

Taken myself off this as @coretl said they will find someone else to pick it up. It's not urgent from our perspective

@coretl
Copy link
Collaborator

coretl commented Dec 12, 2023

I think this will be fixed if we have a generic Mock backend in #94

@coretl
Copy link
Collaborator

coretl commented Jun 17, 2024

Fixed by #94

@coretl coretl closed this as completed Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants