Tidy up core detector module docs #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callumforrester
commented
Mar 27, 2024
|
CI Fix: #164 |
Tidy up core detector module: - Standardise docstrings and update parmaters - Fix public/private methods - Include generic in standard detector mro so the generic argument to prepare() is properly checked
callumforrester
force-pushed
the
tidy-detector-docstrings
branch
from
60a0c2d
to
65fd99e
Compare
callumforrester
changed the title
coretl
approved these changes
Apr 5, 2024
abbiemery
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tidy up core detector module:
prepare() is properly checked