Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create mock signal backend #251

Merged
merged 4 commits into from
May 10, 2024
Merged

Create mock signal backend #251

merged 4 commits into from
May 10, 2024

Conversation

evalott100
Copy link
Contributor

Closes #94

@evalott100 evalott100 self-assigned this Apr 19, 2024
@evalott100 evalott100 marked this pull request as draft April 19, 2024 15:14
@evalott100 evalott100 force-pushed the 94_rename_sim_mock_and_add_softsignalbackend branch 10 times, most recently from 643f684 to 20cbf0d Compare April 25, 2024 14:33
@coretl coretl mentioned this pull request Apr 29, 2024
Open
@evalott100 evalott100 force-pushed the 94_rename_sim_mock_and_add_softsignalbackend branch 3 times, most recently from 04fe4b2 to ab82d7f Compare April 30, 2024 14:18
@evalott100 evalott100 marked this pull request as ready for review April 30, 2024 14:35
coretl
coretl reviewed Apr 30, 2024
View reviewed changes
src/ophyd_async/core/soft_signal_backend.py Outdated Show resolved Hide resolved
src/ophyd_async/core/soft_signal_backend.py Outdated Show resolved Hide resolved
src/ophyd_async/core/mock_signal_backend.py Show resolved Hide resolved
src/ophyd_async/core/mock_signal_backend.py Outdated Show resolved Hide resolved
src/ophyd_async/core/mock_signal_utils.py Outdated Show resolved Hide resolved
src/ophyd_async/core/mock_signal_utils.py Outdated Show resolved Hide resolved
src/ophyd_async/core/mock_signal_utils.py Outdated Show resolved Hide resolved
src/ophyd_async/core/mock_signal_utils.py Outdated Show resolved Hide resolved
src/ophyd_async/core/mock_signal_utils.py Show resolved Hide resolved
@evalott100 evalott100 force-pushed the 94_rename_sim_mock_and_add_softsignalbackend branch 2 times, most recently from d6dcd5c to b1997f8 Compare May 2, 2024 15:08
This was linked to issues May 7, 2024
Initial values on soft signals not carried through to sim #266
Closed
Writing to soft signals fails in sim #267
Closed
This was referenced May 7, 2024
Closed
Closed
@evalott100 evalott100 force-pushed the 94_rename_sim_mock_and_add_softsignalbackend branch from f9bf5a9 to 3802704 Compare May 7, 2024 09:53
@evalott100 evalott100 requested a review from coretl May 7, 2024 09:54
@evalott100 evalott100 force-pushed the 94_rename_sim_mock_and_add_softsignalbackend branch 3 times, most recently from d990e1a to 77b36b0 Compare May 7, 2024 12:40
@evalott100 evalott100 mentioned this pull request May 8, 2024
Merged
@evalott100 evalott100 requested a review from abbiemery May 8, 2024 13:49
abbiemery
abbiemery approved these changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@abbiemery abbiemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a really good chunk of work, awesome job. I approve but I'll let @coretl have the final say before merging.

@evalott100 evalott100 force-pushed the 94_rename_sim_mock_and_add_softsignalbackend branch from 77b36b0 to 2047314 Compare May 8, 2024 15:24
coretl
coretl requested changes May 8, 2024
View reviewed changes
src/ophyd_async/core/soft_signal_backend.py Show resolved Hide resolved
src/ophyd_async/core/signal.py Outdated Show resolved Hide resolved
src/ophyd_async/core/signal.py Show resolved Hide resolved
src/ophyd_async/core/signal.py Outdated Show resolved Hide resolved
src/ophyd_async/core/signal.py Outdated Show resolved Hide resolved
src/ophyd_async/sim/demo/sim_motor.py Outdated Show resolved Hide resolved
tests/epics/motion/test_motor.py Outdated Show resolved Hide resolved
@evalott100 evalott100 mentioned this pull request May 9, 2024
Open
@evalott100 evalott100 force-pushed the 94_rename_sim_mock_and_add_softsignalbackend branch 4 times, most recently from bbc6647 to 14a3408 Compare May 10, 2024 10:27
coretl
coretl requested changes May 10, 2024
View reviewed changes
Copy link
Collaborator

@coretl coretl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there...

src/ophyd_async/core/mock_signal_backend.py Outdated Show resolved Hide resolved
src/ophyd_async/core/mock_signal_backend.py Show resolved Hide resolved
src/ophyd_async/core/mock_signal_backend.py Outdated Show resolved Hide resolved
src/ophyd_async/core/signal.py Show resolved Hide resolved
src/ophyd_async/core/signal.py Outdated Show resolved Hide resolved
@evalott100 evalott100 force-pushed the 94_rename_sim_mock_and_add_softsignalbackend branch 4 times, most recently from d12fbbc to 6e6184d Compare May 10, 2024 10:58
@evalott100
added SoftSignalBackend and MockSignalBackend
ceafcdc 
also added utility functions for `MockSignalBackend` in tests
@evalott100 evalott100 force-pushed the 94_rename_sim_mock_and_add_softsignalbackend branch from 9059bb0 to 1de0a60 Compare May 10, 2024 12:57
@evalott100 evalott100 force-pushed the 94_rename_sim_mock_and_add_softsignalbackend branch from 1de0a60 to 1981eb8 Compare May 10, 2024 13:00
@evalott100 evalott100 requested a review from coretl May 10, 2024 13:07
@coretl coretl merged commit 1e84233 into main May 10, 2024
18 checks passed
@coretl coretl deleted the 94_rename_sim_mock_and_add_softsignalbackend branch May 10, 2024 13:59
@olliesilvester olliesilvester mentioned this pull request May 16, 2024
Closed
@evalott100 evalott100 mentioned this pull request May 16, 2024
Closed
@coretl coretl mentioned this pull request May 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbiemery abbiemery abbiemery approved these changes

@coretl coretl coretl approved these changes

Assignees

@evalott100 evalott100

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@evalott100 @abbiemery @coretl