Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging messages to signals #275

Merged
merged 6 commits into from
May 8, 2024
Merged

Add logging messages to signals #275

merged 6 commits into from
May 8, 2024

Conversation

olliesilvester
Copy link
Contributor

Fixes part of ##195

@olliesilvester olliesilvester requested a review from coretl May 2, 2024 09:27
@olliesilvester olliesilvester mentioned this pull request May 2, 2024
Closed
coretl
coretl reviewed May 2, 2024
View reviewed changes
src/ophyd_async/epics/_backend/_p4p.py Show resolved Hide resolved
tests/core/test_signal.py Outdated Show resolved Hide resolved
@olliesilvester olliesilvester force-pushed the add_unformatted_logging_to_signals branch from f57b038 to c64ebe7 Compare May 3, 2024 12:32
@olliesilvester olliesilvester requested a review from coretl May 3, 2024 12:38
ZLLentz
ZLLentz approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@ZLLentz ZLLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

coretl
coretl reviewed May 7, 2024
View reviewed changes
Copy link
Collaborator

@coretl coretl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of very minor points

src/ophyd_async/core/device.py Show resolved Hide resolved
src/ophyd_async/core/device.py Show resolved Hide resolved
src/ophyd_async/core/signal.py Outdated Show resolved Hide resolved
@olliesilvester olliesilvester merged commit 426b420 into main May 8, 2024
18 checks passed
@olliesilvester olliesilvester deleted the add_unformatted_logging_to_signals branch May 8, 2024 14:11
@coretl coretl mentioned this pull request Jun 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coretl coretl coretl left review comments

@ZLLentz ZLLentz ZLLentz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@olliesilvester @ZLLentz @coretl