Make pilatus deadtime overridable and add tests #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the current Pilatus implementation compatible with a Pilatus2 such that we need to support the current value at all? |
|
Good question, either way the Pilatus 3 manual doesn't specify a deadtime: https://media.dectris.com/user-manual-pilatus3-2020.pdf It seems to be more detector-dependant. |
Found it:
|
|
Nevermind then, I can't read |
|
@coretl Shall we just support the Pilatus 3? |
yes, until someone else asks for an older one |
coretl
reviewed
Jun 4, 2024
| #: The required minimum time difference between ExpPeriod and ExpTime | ||
| #: (readout time) is 2.28 ms | ||
| #: We provide an option to override for newer Pilatus models | ||
| DEFAULT_READOUT_TIME_SECONDS: float = 2.28e-3 |
There was a problem hiding this comment.
Suggested change
| DEFAULT_READOUT_TIME_SECONDS: float = 2.28e-3 | |
| class PilatusReadouttime(Enum): | |
| """Pilatus readout time per model in ms""" | |
| pilatus2 = 2.28e-3 | |
| pilatus3 = 0.95e-3 |
| drv_suffix="cam1:", | ||
| hdf_suffix="HDF1:", | ||
| name="", | ||
| readout_time: float = DEFAULT_READOUT_TIME_SECONDS, |
There was a problem hiding this comment.
Suggested change
| readout_time: float = DEFAULT_READOUT_TIME_SECONDS, | |
| readout_time: PilatusReadoutTime = PilatusReadoutTime.pilatus3, |
callumforrester
force-pushed
the
355-override-pilatus-deadtime
branch
from
4bec3de
to
202ac09
Compare
DiamondJoseph
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #355