-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a panda flyer that is implemented with a pcomp block #430
Adds a panda flyer that is implemented with a pcomp block #430
Conversation
dd9dfca
to
b761049
Compare
@coretl I've added a test that mirrors this: ophyd-async/tests/panda/test_trigger.py Lines 28 to 33 in dbbcf28
But I think we should probably remove them, I'm not sure what the purpose of this is (checking an object has the methods defined in the class). |
10d269c
to
254fd6d
Compare
Not much point in tests like that |
b9b7a5d
to
d8a2df8
Compare
cdd2ae4
to
79b6030
Compare
Also allowed `SubsetEnum` for string `NTScalar`s.
we should probably take out the given methods tests
also tweaked the tests in `test_fly.py`
f93944a
to
11f94b8
Compare
b15923d
to
1fdfd17
Compare
Closes #375