ENH: move the recursive collect_asset_docs up to Device #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks very sensible 👍 Functionally, there's a small change here of only checking kind='normal'- could that be related to some of the area detector test failures? |
1 similar comment
|
This looks very sensible 👍 Functionally, there's a small change here of only checking kind='normal'- could that be related to some of the area detector test failures? |
tacaswell
force-pushed
the
enh_recurse_collect_asset_docs
branch
from
7415212
to
724c805
Compare
|
rebased and tweaked the test a bit. It makes sense that collect asset docs and read should hit the same children. |
klauer
reviewed
May 10, 2022
| @@ -1237,6 +1237,11 @@ def read(self): | |||
| res.update(component.read()) | |||
| return res | |||
|
|
|||
| def collect_asset_docs(self): | |||
|
Yup, this is super broken and I have no idea why :( I assume multiple inheritance is involved.... |
tacaswell
force-pushed
the
enh_recurse_collect_asset_docs
branch
from
724c805
to
06f5cfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While talking to @jklynch about how asset document collection works I noted that the recursive fallback was implemented in the
AreaDetectorrelated classes. As part of a push to refactor and (hopefully) simplify how we manage external resources it would be good to pull the recursive discovery and accumulation up to theDevicelevel.