Ophyd v2: add _exception to AsyncStatus to propagate errors through FailedStatus. #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Per matplotlib/matplotlib#25406 we should at have a think about keeping a reference to the exception. I think in this case we (and the v1 status objects) we want to do this so we can move the exceptions around, but we should be sure. |
tacaswell
reviewed
Mar 16, 2023
coretl
reviewed
Mar 17, 2023
added 4 commits
March 17, 2023 15:04
… and that a normal non-failing coroutine without being cancelled has an exception of None
|
At this point, I think I've tested every line I've added in the ophyd v2 core.py file... Should I write some more tests for anything else? Maybe for the v1 part? |
coretl
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added ._exception to AsyncStatus to match with method in v1 Status object
Solves #1098
This will be followed by a PR in bluesky, which will change the Status object that ophyd v2 AsyncStatus inherits from as well as how FailedStatus gets instantiated. Once I have done this, I will link it here so the changes can be viewed together.