Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate draw logic #45

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Remove duplicate draw logic #45

merged 1 commit into from
Jan 7, 2022

Conversation

thomascobb
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #45 (513c9b5) into master (800bb03) will increase coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
+ Coverage   95.02%   95.38%   +0.36%     
==========================================
  Files           9        9              
  Lines         904      889      -15     
==========================================
- Hits          859      848      -11     
+ Misses         45       41       -4     
Impacted Files Coverage Δ
src/scanspec/plot.py 88.65% <ø> (+2.35%) ⬆️
src/scanspec/sphinxext.py 41.17% <0.00%> (-3.27%) ⬇️
src/scanspec/cli.py 90.00% <0.00%> (-0.63%) ⬇️
src/scanspec/service.py 89.88% <0.00%> (-0.33%) ⬇️
src/scanspec/core.py 99.06% <0.00%> (-0.01%) ⬇️
src/scanspec/specs.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 800bb03...513c9b5. Read the comment docs.

@thomascobb
Copy link
Contributor Author

skip-lock builds fail because of wyfo/apischema#316

@thomascobb thomascobb merged commit 22ae64c into master Jan 7, 2022
@thomascobb thomascobb deleted the remove-draw-logic branch January 7, 2022 10:32
@thomascobb thomascobb mentioned this pull request Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants