add first-class support for discrete hardware #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksunden
reviewed
Aug 14, 2023
yaqc_bluesky/_is_discrete.py
Outdated
| out = super()._describe(out) | ||
| meta = OrderedDict() | ||
| meta["shape"] = [] | ||
| meta["dtype"] = "string" |
There was a problem hiding this comment.
The identifier can be null, not sure if that can be declared here or needs to be handled, e.g. by mapping None to empty string
There was a problem hiding this comment.
Great point. I guess I'll have to try and feed nulls into Bluesky to see what happens. If Bluesky gets angry we can do empty string easily.
There was a problem hiding this comment.
None works just fine, with the exception of formatting for best effort callback. The messages get emitted and data gets recorded.
I guess now we have to decide, but I think keeping it as-is makes sense.
* setter not getter * tests * rm print
ksunden
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.