Remove the call to isAlive() which is broken #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The update of glibc from 2.31 to 2.35 in Ubuntu changed the semantics of pthread_kill. It used to return an error when a dead thread exited, and now it returns 0. This new behavior is POSIX-compatible as the result of pthread_kill on a thread that died produces undefined behavior, so techincally 0 is valid result. This isAlive() will return that a dead thread is alive in the newer glibc versions. This patch removes the use of isAlive and instead uses tryjoin, which should behave correctly for dead threads.
|
This patch needs more work tho, with error conditions not being correctly handled. Hold off on accepting it please |
|
This commit helped me to fix #16. |
do not spin forever if some thread is invalid or it's a EDEADLK
|
I've added a missing check for error, so this should be good to go. |
thomasemter
added a commit
to thomasemter/bluespace_ai_xsens_ros_mti_driver
that referenced
this pull request
Jan 25, 2023
bukharyi
added a commit
to MIMOSRobotics/bluespace_ai_xsens_ros_mti_driver
that referenced
this pull request
Mar 2, 2023
reference 1. https://github.com/bluespace-ai/bluespace_ai_xsens_ros_mti_driver/pull/17/files 2. bluespace-ai#17 The update of glibc from 2.31 to 2.35 in Ubuntu changed the semantics of pthread_kill. It used to return an error when a dead thread exited, and now it returns 0. This new behavior is POSIX-compatible as the result of pthread_kill on a thread that died produces undefined behavior, so techincally 0 is valid result. This isAlive() will return that a dead thread is alive in the newer glibc versions. This patch removes the use of isAlive and instead uses tryjoin, which should behave correctly for dead threads.
This was
linked to
issues
Apr 6, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update of glibc from 2.31 to 2.35 in Ubuntu changed the semantics of pthread_kill. It used to return an error when a dead thread exited, and now it returns 0.
This new behavior is POSIX-compatible as the result of pthread_kill on a thread that died produces undefined behavior, so techincally 0 is valid result.
This isAlive() will return that a dead thread is alive in the newer glibc versions.
This patch removes the use of isAlive and instead uses tryjoin, which should behave correctly for dead threads.